Skip to content

refactor(framework): Update eslint config in packages/framework/dds-interceptions to extend "recommended" base config #24806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2025
Merged

refactor(framework): Update eslint config in packages/framework/dds-interceptions to extend "recommended" base config #24806

merged 5 commits into from
Jun 17, 2025
+54 −42

Conversation

jikim-msft
Copy link
Contributor

Description

3036

Updates the eslint-config of dds-interception package from minimal to recommended.

@github-actions github-actions bot added base: main PRs targeted against main branch area: dds Issues related to distributed data structures area: dds: tree area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct public api change Changes to a public API labels Jun 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  222981 links
    1707 destination URLs
    1939 URLs ignored
       0 warnings
       0 errors

@github-actions github-actions bot removed area: dds Issues related to distributed data structures public api change Changes to a public API area: dds: tree labels Jun 10, 2025
@jikim-msft jikim-msft marked this pull request as ready for review June 10, 2025 18:12
@jikim-msft jikim-msft requested a review from Josmithr June 10, 2025 18:12
Josmithr
Josmithr reviewed Jun 10, 2025
View reviewed changes
packages/dds/tree/api-report/tree.alpha.api.md Outdated
@@ -424,17 +424,17 @@ export namespace JsonAsTree {
}
const // @system
_APIExtractorWorkaroundObjectBase: TreeNodeSchemaClass<"com.fluidframework.json.object", NodeKind.Map, System_Unsafe.TreeMapNodeUnsafe<readonly [LeafSchema<"null", null>, LeafSchema<"number", number>, LeafSchema<"string", string>, LeafSchema<"boolean", boolean>, () => typeof JsonObject, () => typeof Array]> & WithType<"com.fluidframework.json.object", NodeKind.Map, unknown>, {
[Symbol.iterator](): Iterator<[string, string | number | JsonObject | Array | System_Unsafe.InsertableTypedNodeUnsafe<LeafSchema<"boolean", boolean>, LeafSchema<"boolean", boolean>> | null], any, undefined>;
[Symbol.iterator](): Iterator<[string, string | number | System_Unsafe.InsertableTypedNodeUnsafe<LeafSchema<"boolean", boolean>, LeafSchema<"boolean", boolean>> | JsonObject | Array | null], any, undefined>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file are unrelated and should be reverted :)

Copy link
Contributor Author

@jikim-msft jikim-msft Jun 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird, I see this change in a particular commit not included in the overall change. I think pulling the change and running local build in this branch has caught up with the upstream head?

Josmithr
Josmithr requested changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to revert the two API report changes (they are unrelated to your code changes). Otherwise, this looks good to me!

@jikim-msft jikim-msft requested a review from Josmithr June 17, 2025 17:41
@jikim-msft jikim-msft enabled auto-merge (squash) June 17, 2025 17:41
Josmithr
Josmithr approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jikim-msft jikim-msft merged commit 2c37283 into microsoft:main Jun 17, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josmithr Josmithr Josmithr approved these changes

Assignees
No one assigned
Labels
area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct base: main PRs targeted against main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jikim-msft @Josmithr